Captcha V2 #14
Merged
Captcha V2 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perimeterx/px_blocker.py
Outdated
| headers = ctx.get('headers') | ||
| if ctx.get('block_action') is not 'r': | ||
| for item in headers.keys(): | ||
| if (item.lower() is 'accept' or item.lower() is 'content-type') and headers[item] is 'application/json': |
There was a problem hiding this comment.
headers[item] may be a comma separated string, where application/json is just one element, so you should check if it's contained rather than equal
|
|
||
| def is_json_response(self, ctx): | ||
| headers = ctx.get('headers') | ||
| if ctx.get('block_action') is not 'r': |
There was a problem hiding this comment.
you call is_json_response after the check in the main flow that block action is not r, so this is a bit redundant
Contributor
Author
There was a problem hiding this comment.
That's not redundant, It sets the content-type, even if the block_Action is 'r' it will get there
| blocking_response = self.mustache_renderer.render(px_template.get_template(px_constants.BLOCK_TEMPLATE), blocking_props) | ||
| is_json_response = self.is_json_response(ctx) | ||
| if is_json_response: | ||
| content_type = 'application/json' |
There was a problem hiding this comment.
if it's json response, then the response shouldn't be a compiled html template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.